On 10/09/2018 11:13, Jan Beulich wrote:
>
>> Equally, it may still be able to service #MC's, so I can't see how it is
>> safe for us to ever free the percpu data.
> I'm having trouble seeing how this remark relates to the series here.

Because you've tried to make NMIs safe, but not made equivalent
adjustments to the #MC side of things.

> Plus it's a theoretical problem at present only anyway:
> - physical hot remove is not implemented (there's no source of the
>   new CPU_REMOVE notification),
> - Intel CPUs get parked, i.e. never have their per-CPU data freed,
> - AMD CPUs don't broadcast #MC.

Ignoring MCE's is never an option, but whenever CR4.MCE is set, we must
be prepared to handle #MC.  Just because an AMD CPU is playing dead
doesn't mean it is immune to receiving #MC's.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to