George Dunlap writes ("Re: [PATCH 8/9] libxl: Kill QEMU by uid when possible"):
> It wouldn’t be terribly hard to have a common “exit” to both the
> kill-by-pid and kill-by-uid paths that did it once, but it would
> involve adding Yet Another Function; and each additional function
> makes the code a little bit more difficult to follow.I'm afraid I disagree on this point. I agree that additional functions should be avoided where they are needless. But a single exit path is more important. Without a single exit path, someone who modifies this code in the fututure (to add new state, say) will risk altering only one of the exit paths. Ian. _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
