On Thu, Nov 29, 2018 at 11:31:41AM +0000, Anthony PERARD wrote: > On Wed, Nov 28, 2018 at 05:43:33PM +0000, Wei Liu wrote: > > OVMF has become dependent on OpenSSL, which it is included as a submodule. > > Initialise submodules before building. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > --- > > This should fix the build breakage for OVMF branch in OSSTEST. > > > > Cc: Anthony PERARD <anthony.per...@citrix.com> > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > --- > > tools/firmware/ovmf-makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile > > index 2838744461..3de2fc0300 100644 > > --- a/tools/firmware/ovmf-makefile > > +++ b/tools/firmware/ovmf-makefile > > @@ -16,6 +16,7 @@ all: build > > > > .PHONY: build > > build: > > + $(GIT) submodule update --init --recursive > > OvmfPkg/build.sh -a X64 -b $(TARGET) -n 4 > > cp Build/OvmfX64/$(TARGET)_GCC*/FV/OVMF.fd ovmf.bin > > > > What about the release tarball? Do we includes OVMF in it?
Yes we do. But this should work because the Makefile is also shipped. What does qemu-xen do regarding its submodules? OVMF should just follow suite. > > Also, doesn't osstest needs some updates? I forgot if there is something > to do when projects have submodules. Yes there is some special arrangement for libvirt. Not sure what needs to be done for OVMF since it is part of xen.git. Ian? Wei. > > -- > Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
