> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, November 15, 2018 11:31 PM > > On 15/11/2018 15:28, Sergey Dyasli wrote: > > On 15/11/2018 13:52, Andrew Cooper wrote: > >> This ends up corrupting L1's view of RFLAGS by setting ZF. The correct > value > >> is established earlier in the function. > > vmsucceed() doesn't set any flags, only clears some. And in this function > it's > > just redundant. ZF is set by VMfailValid. So I think the description must be > > changed. > > Oh - so it does. Yes - I was confusing it with the failvalid case. > I'll fix the wording to "The correct RFLAGS value is established earlier > in the function, and this call has no net effect." >
with wording fixed, Acked-by: Kevin Tian <kevin.t...@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
