On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:38 +0100 > Samuel Ortiz <sa...@linux.intel.com> wrote: > > > This is the standard way of building SRAT on x86 platfoms. But future > > machine types could decide to define their own custom SRAT build method > > through the ACPI builder methods. > > Moreover, we will also need to reach build_srat() from outside of > > acpi-build in order to use it as the ACPI builder SRAT build method. > SRAT is usually highly machine specific (memory holes, layout, guest OS > specific quirks) so it's hard to generalize it. Hence the need for an SRAT builder interface.
> I'd drop SRAT related patches from this series and introduce > i386/virt specific SRAT when you post patches for it. virt uses the existing i386 build_srat() routine, there's nothing special about it. So this would be purely duplicated code. Cheers, Samuel. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel