On 10/11/18 2:44 PM, Dario Faggioli wrote:
> Load balancing, when happening, at the end of a "scheduler epoch", can
> trigger vcpu migration, which in its turn may call runq_tickle(). If the
> cpu where this happens was idle, but we're now going to schedule a vcpu
> on it, let's update the runq's idle cpus mask accordingly _before_ doing
> load balancing.
> 
> Not doing that, in fact, may cause runq_tickle() to think that the cpu
> is still idle, and tickle it to go pick up a vcpu from the runqueue,
> which might be wrong/unideal.
> 
> Signed-off-by: Dario Faggioli <dfaggi...@suse.com>

Patch looks good:

Reviewed-by: George Dunlap <george.dun...@citrix.com>

One comment: The title seems to have excessive tags.  You only need
enough for people scrolling through to figure out the domain;
"xen/credit2:", or even just "credit2:" is enough.  More than that makes
the line too long and can obscure important information if the lines end
up being clipped.

Do you mind if I change that on check-in?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to