On 11/21/18 3:21 PM, Andrew Cooper wrote: > The final parameter to p2m_altp2m_lazy_copy() appears to be unnecessary, and > results in very hard-to-follow code. Have the sole caller set its local p2m > pointer appropriately, and drop the parameter. > > With that done, a level of indirection of ap2m can be dropped inside > p2m_altp2m_lazy_copy(). While changing the API, switch it from bool_t to > bool, and drop printing of the altp2m's virtual address, because it is of no > use even when debugging. > > No (intended) overall change in behaviour. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Right, I see you've changed the return type of p2m_altp2m_lazy_copy() from bool_t to bool here, so please disregard my previous comment. Reviewed-by: Razvan Cojocaru <rcojoc...@bitdefender.com> Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
