> -----Original Message----- > From: Xen-devel [mailto:[email protected]] On Behalf > Of Paul Durrant > Sent: 06 November 2018 08:44 > To: Ian Jackson <[email protected]>; [email protected] > Cc: Ian Jackson <[email protected]>; Wei Liu <[email protected]> > Subject: Re: [Xen-devel] [PATCH 3/3] tools: ipxe: Correct download error > handling > > > -----Original Message----- > > From: Ian Jackson [mailto:[email protected]] > > Sent: 05 November 2018 18:43 > > To: [email protected] > > Cc: Ian Jackson <[email protected]>; Paul Durrant > > <[email protected]>; Wei Liu <[email protected]> > > Subject: [PATCH 3/3] tools: ipxe: Correct download error handling > > > > This shell fragment lacked set -e. So, eg if the download failed a > > broken ipxe.tar.gz would be left behind. > > > > Signed-off-by: Ian Jackson <[email protected]> > > CC: Paul Durrant <[email protected]> > > CC: Wei Liu <[email protected]> > > Reviewed-by: Paul Durrant <[email protected]>
Also... Tested-by: Paul Durrant <[email protected]> (using a poisoned tarball name and the fact that ipxe still can't be accessed via git://) > > > --- > > tools/firmware/etherboot/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/firmware/etherboot/Makefile > > b/tools/firmware/etherboot/Makefile > > index 3868f876ea..fd8dfdf5a7 100644 > > --- a/tools/firmware/etherboot/Makefile > > +++ b/tools/firmware/etherboot/Makefile > > @@ -33,7 +33,7 @@ $(ROM): $(ROMS) > > $(MAKE) -C $D/src bin/$(*F).rom > > > > $T: > > - if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \ > > + set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \ > > $(GIT) clone $(IPXE_GIT_URL) $D.git; \ > > (cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \ > > $(IPXE_GIT_TAG) | gzip -n >../_$T); \ > > -- > > 2.11.0 > > > _______________________________________________ > Xen-devel mailing list > [email protected] > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
