Hi Stefano,

On 05/10/2018 19:47, Stefano Stabellini wrote:
+static int __init make_gic_domU_node(const struct domain *d, void *fdt)
+{
+    switch ( gic_hw_version() )

While I understand that today domains will use the same GIC version as the host, it would be best if we don't rely on this in the generation of the DT.

So I would use d->arch.vgic.version here.

With that change:

Acked-by: Julien Grall <julien.gr...@arm.com>


+    {
+    case GIC_V3:
+        return make_gicv3_domU_node(d, fdt);
+    case GIC_V2:
+        return make_gicv2_domU_node(d, fdt);
+    default:
+        panic("Unsupported GIC version");
+    }
+}

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to