On Mon, Oct 15, 2018 at 11:36:18AM +0100, Andrew Cooper wrote: > In particular, initialising %dr6 with the value 0 is buggy, because on > hardware supporting Transnational Memory, it will cause the sticky RTM bit to > be asserted, even though a debug exception from a transaction hasn't actually > been observed. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Roger Pau Monné <roger....@citrix.com> > --- > CC: Ian Jackson <ian.jack...@citrix.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Roger Pau Monné <roger....@citrix.com> > > The correct way to do this would be to get/modify/set the vcpu state, but it > turns out that is impossible for an HVM vcpu which hasn't yet had state set. > Fixing that is going to take some substantial untangling from implications in > the migration stream. > --- > tools/libxc/xc_dom_x86.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c > index 77a4c6c..9e279d6 100644 > --- a/tools/libxc/xc_dom_x86.c > +++ b/tools/libxc/xc_dom_x86.c > @@ -53,6 +53,9 @@ > #define X86_CR0_PE 0x01 > #define X86_CR0_ET 0x10 > > +#define X86_DR6_DEFAULT 0xffff0ff0u > +#define X86_DR7_DEFAULT 0x00000400u Would be nice to share the same defines between the hypervisor and the tools, but that's out of the scope. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
