> -----Original Message----- > From: Roger Pau Monne > Sent: 10 October 2018 10:13 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>; xen-devel@lists.xenproject.org; Jan > Beulich <jbeul...@suse.com> > Subject: Re: [Xen-devel] [PATCH] iommu: fix arm build after e9be34be5 > > On Wed, Oct 10, 2018 at 09:59:21AM +0100, Paul Durrant wrote: > > > -----Original Message----- > > > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On > Behalf > > > Of Wei Liu > > > Sent: 09 October 2018 19:58 > > > To: xen-devel@lists.xenproject.org > > > Cc: Wei Liu <wei.l...@citrix.com>; Jan Beulich <jbeul...@suse.com>; > Roger > > > Pau Monne <roger....@citrix.com> > > > Subject: [Xen-devel] [PATCH] iommu: fix arm build after e9be34be5 > > > > > > The function iommu_share_p2m_table is used by both ARM and x86 but > > > hap_enabled macro is x86 only. Put the ASSERT under CONFIG_X86. > > > > Would it be unreasonable to make hap_enabled() common and define it to > true for ARM? > > I assumed hap_enabled was hardcoded to true for ARM, but it's only > used in x86 code and vm_event so far (and here now), so I'm not sure > if it's worth it. > > In any case, I think this should go in as it fixes the build, and > adding hap_enabled for ARM can be done later. >
Oh yes. It can certainly be tidied later. Paul > Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
