> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 October 2018 15:51 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Brian Woods <brian.wo...@amd.com>; Suravee Suthikulpanit > <suravee.suthikulpa...@amd.com>; Julien Grall <julien.gr...@arm.com>; > Andrew Cooper <andrew.coop...@citrix.com>; Wei Liu <wei.l...@citrix.com>; > George Dunlap <george.dun...@citrix.com>; Ian Jackson > <ian.jack...@citrix.com>; Jun Nakajima <jun.nakaj...@intel.com>; Kevin > Tian <kevin.t...@intel.com>; Stefano Stabellini <sstabell...@kernel.org>; > xen-devel <xen-devel@lists.xenproject.org>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Tamas K Lengyel <ta...@tklengyel.com>; Tim > (Xen.org) <t...@xen.org> > Subject: Re: [PATCH v14 9/9] mm / iommu: split need_iommu() into > has_iommu_pt() and need_iommu_pt_sync() > > >>> On 04.10.18 at 12:45, <paul.durr...@citrix.com> wrote: > > The name 'need_iommu()' is a little confusing as it suggests a domain > needs > > to use the IOMMU but something might not be set up yet, when in fact it > > represents a tri-state value (not a boolean as might be expected) where > > -1 means 'IOMMU mappings being set up' and 1 means 'IOMMU mappings have > > been fully set up'. > > > > Two different meanings are also inferred from the macro it in various > > places in the code: > > > > - Some callers want to test whether a domain has IOMMU mappings at all > > - Some callers want to test whether they need to synchronize the > domain's > > P2M and IOMMU mappings > > > > This patch replaces the 'need_iommu' tri-state value with a defined > > enumeration and adds a boolean flag 'need_sync' to separate these > meanings, > > and places both of these in struct domain_iommu, rather than directly in > > struct domain. > > This patch also creates two new boolean macros: > > > > - 'has_iommu_pt()' evaluates to true if a domain has IOMMU mappings, > even > > if they are still under construction. > > - 'need_iommu_pt_sync()' evaluates to true if a domain requires explicit > > synchronization of the P2M and IOMMU mappings. > > > > All callers of need_iommu() are then modified to use the macro > appropriate > > to what they are trying to test, except for the instance in > > xen/drivers/passthrough/pci.c:assign_device() which has simply been > > removed since it appears to be unnecessary. > > > > NOTE: There are some callers of need_iommu() that strictly operate on > > the hardware domain. In some of these case a more global flag is > > used instead. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > Acked-by: Razvan Cojocaru <rcojoc...@bitdefender.com> > > Presumably as a result of leaving out patch 4, this patch had quite a > bit of fuzz when applying. Would you please double check that I > didn't screw things up? >
Certainly the commit looks fine. I'll re-base my PV-IOMMU series and re-test it... probably not until next week though. Paul > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
