On 05/10/18 12:31, Jan Beulich wrote:
> A few pieces of the handling here are (no longer?) vendor specific, and
> hence there's no point in replicating the code.

EFER probably was vendor specific originally.  The control registers
really shouldn't have been...

> Make sure not otherwise
> pre-filled fields of struct hvm_hw_cpu instances are zero filled before
> calling the vendor "save" hook, eliminating the need for the hook
> functions to zero individual fields.

The start of this sentence is rather hard to parse.  How about "Zero the
full structure before calling the save hook, eliminating the need to
zero individual fields." ?

> Signed-off-by: Jan Beulich <jbeul...@suse.com>

Code wise, this looks fine.  Reviewed-by: Andrew Cooper
<andrew.coop...@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to