On 10/01/2018 03:00 PM, Jan Beulich wrote: >>>> On 01.10.18 at 15:38, <george.dun...@citrix.com> wrote: >> On 10/01/2018 12:25 PM, Jan Beulich wrote: >>> I think the main concern >>> was with the way migration of the new value was implemented. But I >>> really have to defer to Andrew for that, irrespective of him not >>> having responded (on the list) to prior pings. >> >> Is Andrew really the only person who knows enough about migration to >> give this the thumbs-up? > > That's not the point here, at least afaic: He had voiced _some_ > concern on an earlier version. In such a case it is, I think, only > appropriate to wait with committing until there was indication > that the concerns were sufficiently addressed (verbally or by > adjustments to the code).
Right -- but it's not your job to make sure the migration stuff is properly addressed; it's Wei and Ian's job. Wei's R-b was a statement from him that the code was good; when Andy questioned that, I think it was then *Wei's* job to address the question, not yours or Andy's (or even Olaf's). If Wei says, "I've considered Andy's objections and I think the patch is fine as-is", then it can be checked in (given a reasonable amount of time for Andy to respond); and Wei can own whatever consequences there are. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
