>>> On 19.09.18 at 10:01, <paul.durr...@citrix.com> wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Paul Durrant >> Sent: 19 September 2018 08:56 >> >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 19 September 2018 07:03 >> > >> > >>> On 18.09.18 at 18:37, <paul.durr...@citrix.com> wrote: >> > > Moving to p2m-common won't work. The function declaration involves a >> > > p2m_type_t argument and that enum is defined in the arm and x86 >> specific >> > > headers. I propose therefore to leave this patch as-is. >> > >> > Leaving the duplication in place is just the last resort imo. Does >> > xen/mm.h >> > not work either? >> >> No, it won't. It has to be something *after* the definition of the >> p2m_type_t enum. I could, as Julien suggested, move the inclusion of p2m- >> common after that point, but it would mean the header guards would cease >> to DTRT of course. I'm not sure whether C will allow me to forward declare >> the enum (not something I've tried) but I could give that a go. Any other >> suggestions? >> > > Forward declaration of the enum does indeed appear to work, so I'll go with > that.
That's an extension I'm not even sure all gcc versions support (I've checked 4.3 just now, where it works). Roger, any chance you know whether clang supports this? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
