On 21/08/2018 12:48, Jan Beulich wrote: >>>> On 17.08.18 at 17:12, <wei.l...@citrix.com> wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -60,6 +60,12 @@ config PV_LINEAR_PT >> >> config HVM >> def_bool y >> + prompt "HVM / PVH support" >> + ---help--- >> + Interfaces to support HVM and PVH guests. >> + >> + If unsure, say Y. > As said before, this wants to gain a dependency on !PV_SHIM_EXCLUSIVE.
No - it should not. Dependencies force options to be hidden in Kconfig, which lead to very poor use experience for people trying to find an option they expect to be available. There no functional dependency between HVM and PV_SHIM_EXCLUSIVE, so there should be no dependency in Kconfig. PV_SHIM_EXCLUSIVE should probably recommend in its help text to disable HVM, but that is the most which Kconfig should influence. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
