>>> On 17.08.18 at 17:12, <wei.l...@citrix.com> wrote: > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -92,8 +92,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) > min(sizeof(pi->hw_cap), sizeof(boot_cpu_data.x86_capability))); > if ( hvm_enabled ) > pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm; > - if ( iommu_enabled ) > + if ( hvm_enabled && iommu_enabled ) > pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm_directio; > + else if ( iommu_enabled ) > + pi->capabilities |= XEN_SYSCTL_PHYSCAP_directio; > }
At the sysctl layer I think you can, as suggested iirc by Roger, simply replace hvm_directio with directio (or iommu). For the "xl info" output, otoh, I'm afraid this doesn't hold, as people may parse for the string. Depending on how this would best be addressed in the tool stack, replacing the sysctl names may then no longer be the most suitable solution. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
