>>> On 17.08.18 at 11:29, <roger....@citrix.com> wrote: > On Fri, Aug 17, 2018 at 03:20:11AM -0600, Jan Beulich wrote: >> Rather than special casing the ->iomem_caps check in x86's >> get_page_from_l1e() for the dom_xen case, let's be more tolerant in >> general, along the lines of rangeset_is_empty(): A never allocated >> rangeset can't possibly contain or overlap any range. >> >> Reported-by: Andrew Cooper <andrew.coop...@citrix.com> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > LGTM: > > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Thanks. > As said in the commit message, this is done to avoid an extra check in > get_page_from_l1e I assume, so should the extra check also be dropped > here? I'm afraid I don't understand: I indeed mean to avoid adding a NULL check in get_page_from_l1e(). But what check are you thinking of that could be dropped? Or in other words, what is "here" in your reply? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
