Hi Stefano,
On 08/15/2018 09:04 PM, Stefano Stabellini wrote:
On Mon, 13 Aug 2018, Julien Grall wrote:
+void __init create_domUs(void)
+{
+ struct dt_device_node *node;
+ struct dt_device_node *chosen = dt_find_node_by_name(dt_host,
"chosen");
+
+ if ( chosen != NULL )
+ {
+ dt_for_each_child_node(chosen, node)
+ {
+ struct domain *d;
+ struct xen_domctl_createdomain d_cfg = {
+ .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE,
+ .arch.nr_spis = 32,
AFAICT, when creating DomU from the toolstack nr_spis will be 0. So why 32
here?
Legacy from debug code. It should be 0, unless vpl011 is enabled, in
which case it should be 1.
I would prefer if we use GUEST_VPL011_SPI - 32. This would make the code
bullet-proof for any potential reshuffle of the IRQs.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
