On Wed, Aug 01, 2018 at 10:36:26AM -0400, Jason Andryuk wrote: > On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki > <marma...@invisiblethingslab.com> wrote: > > This allows using arguments with spaces, like -append. > > Stubdomain side of this require "xenstore-client: Add option for raw > > in-/output" commit. > > I had to look up \x1b - it is ascii escape. Since I was on the > www.asciitable.com, I saw \x1e is "record seperator" which might make > more sense.
Simon, do you remember why you used \x1b? Otherwise indeed changing to \x1e would make sense. > Either way, the code is fine. It would be good to document the > separator and other interface assumptions like the FDs in a > linux-stubdom document. Yes, definitely, already proposed in cover letter, including initial description of the interface. > Reviewed-by: Jason Andryuk <jandr...@gmail.com> -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
