On 15.01.2026 16:17, Julian Vetter wrote: > Currently the CONFIG_REQUIRE_NX prevents booting XEN, if NX is disabled > in the BIOS.
Which is what the config option's name says? IOW if this wants changing, more wants saying here. > AMD doesn't have a software-accessible MSR to re-enable it, > so there is nothing we can do. The system is going to die anyway. But on > Intel NX might just be hidden via IA32_MISC_ENABLE.XD_DISABLE. But the > function to re-enable it is called after the check + panic in > efi_arch_cpu. So, this patch removes the early check and moves the > entire NX handling into a dedicated place. > > Signed-off-by: Julian Vetter <[email protected]> > --- > xen/arch/x86/boot/head.S | 56 -------------------------------- > xen/arch/x86/boot/trampoline.S | 5 ++- > xen/arch/x86/cpu/intel.c | 4 --- > xen/arch/x86/efi/efi-boot.h | 12 ------- > xen/arch/x86/include/asm/setup.h | 2 ++ > xen/arch/x86/setup.c | 46 ++++++++++++++++++++++++++ > 6 files changed, 50 insertions(+), 75 deletions(-) Wasn't there some earlier variant of this? I.e. is this a v2 (or higher), where it might help if changes made were briefly called out? Still need to look at the patch as a whole ... Jan
