On 2026-01-15 11:17, Jan Beulich wrote:
On 14.01.2026 21:56, Nicola Vetrini wrote:
On 2026-01-14 21:40, Jason Andryuk wrote:
On 2026-01-14 13:27, Nicola Vetrini wrote:
--- a/xen/arch/x86/cpu/mcheck/mce-apei.c
+++ b/xen/arch/x86/cpu/mcheck/mce-apei.c
@@ -74,7 +74,8 @@ int apei_write_mce(struct mce *m)
rcd.hdr.record_id = cper_next_record_id();
rcd.hdr.flags = CPER_HW_ERROR_FLAGS_PREVERR;
- rcd.sec_hdr.section_offset = (void *)&rcd.mce - (void *)&rcd;
+ rcd.sec_hdr.section_offset = offsetof(struct cper_mce_record, mce)
-
+ offsetof(struct cper_mce_record, hdr);
"= offsetof(struct cper_mce_record, mce);" should be sufficient since
the offset of hdr is 0?
Yeah, makes sense. Given that the struct layout is coming from the
UEFI
spec it's not likely to change either.
It's okay either way, but I'm happy to adjust to the simpler form while
committing (I'd slightly prefer that, precisely for being simpler, and
it
being close to what was there originally):
Acked-by: Jan Beulich <[email protected]>
(ftaod: either way).
Jan
Thanks
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
