On 15.01.2026 10:50, Andrew Cooper wrote:
> Fixes: a6ed4543222a ("x86/time: pv_soft_rdtsc() is PV-only")
> Signed-off-by: Andrew Cooper <[email protected]>Why Fixes: without you calling out what bug it is that is being fixed (and that was introduced by said commit)? That's really where I think Amends: is to be used, but yes, I know you dislike that new tag. The Misra rule 2.2 (dead code) violation was pre-existing to the named commit. Plus that rule isn't among the accepted ones, i.e. while we should strive to not have violations, having ones isn't quite a "bug" (yet). But yes - I probably could / should have noticed this and done the change right while moving the function. Without the tag, or with it changed to Amends: Acked-by: Jan Beulich <[email protected]> Jan
