On 13.01.2026 16:19, Andrew Cooper wrote: > On 13/01/2026 3:00 pm, Alejandro Vallejo wrote: >> On Tue Jan 13, 2026 at 3:24 PM CET, Andrew Cooper wrote: >>> On 13/01/2026 12:21 pm, Alejandro Vallejo wrote: >>>> It's only used for microcode loading on x86. By lib-ifying it we can make >>>> it go away automatically when microcode loading becomes an optional >>>> feature in follow-up patches. >>>> >>>> Signed-off-by: Alejandro Vallejo <[email protected]> >>>> --- >>>> v3: >>>> * New patch. Subsumes earlier conditionalisation of earlycpio.c on >>>> CONFIG_MICROCODE_LOADING. >>>> --- >>>> docs/misra/exclude-list.json | 8 ++++---- >>>> xen/common/Makefile | 2 +- >>>> xen/lib/Makefile | 1 + >>>> xen/{common => lib}/earlycpio.c | 0 >>>> 4 files changed, 6 insertions(+), 5 deletions(-) >>>> rename xen/{common => lib}/earlycpio.c (100%) >>>> >>>> diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json >>>> index 388397dd3b..2b874dfd3b 100644 >>>> --- a/docs/misra/exclude-list.json >>>> +++ b/docs/misra/exclude-list.json >>>> @@ -121,10 +121,6 @@ >>>> "rel_path": "common/bunzip2.c", >>>> "comment": "Imported from Linux, ignore for now" >>>> }, >>>> - { >>>> - "rel_path": "common/earlycpio.c", >>>> - "comment": "Imported from Linux, ignore for now" >>>> - }, >>>> { >>>> "rel_path": "common/gzip/*", >>>> "comment": "Imported from Linux, ignore for now" >>>> @@ -225,6 +221,10 @@ >>>> "rel_path": "include/xen/decompress.h", >>>> "comment": "Imported from Linux, ignore for now" >>>> }, >>>> + { >>>> + "rel_path": "lib/earlycpio.c", >>>> + "comment": "Imported from Linux, ignore for now" >>>> + }, >>>> { >>>> "rel_path": "lib/find-next-bit.c", >>>> "comment": "Imported from Linux, ignore for now" >>> Honestly, I think this needs simply dropping. "ignore for now" isn't >>> going to cut it with any competent evaluators. >> That would depend on justifications and such. But regardless clearing the >> exclusion list is a different matter aside from removing microcode loading. >> >>> By libryfing it, it's no longer part of the AMD target build, but it >>> does want covering by *-allcode. >>> >>> Given that you noticed it for v2, I presume there's something in the >>> file that Eclair doesn't like? >> I didn't run Eclair on it. It's ignored as part of common, and the build >> fails in CI if the file in common is absent. That's how I noticed it. >> >> I'd rather not gate this particular change on earlycpio playing ball with >> Eclair. > > I'm explicitly not gating it. *-allcode is non-blocking, but I want > earlycpio being scanned.
In fairness to Alejandro - you're asking for an entirely unrelated change. If it was really just ... > Simply omitting the second hunk should do this, and not explode the AMD > target build. (Once this patch is reordered to the end of the series.) ... this, then probably okay(ish). But afaict MICROCODE_LOADING needs to then be turned off for *-amd, which patch 4 doesn't do (yet) afaics. Jan
