On Mon, Jan 12, 2026 at 12:24 PM Jan Beulich <[email protected]> wrote: > > On 12.01.2026 12:18, Andrew Cooper wrote: > > On 12/01/2026 11:09 am, Jan Beulich wrote: > >> You didn't even Cc Tamas, who I think once again will need to ack this.
I _considered_ Ccing Tamas when I saw add_maintainers.pl didn't add him. I couldn't remember if I added him manually at that time or not. However, in the end, I just trusted the add_maintainers.pl and didn't modify it. > >> However, two formal points: Please use 12-digit hashes, as demanded by > >> sending-patches.pandoc. I apologize. This is the first time I'm learning of the existence of sending-patches.pandoc. Up until now I was following the "Submitting_Xen_Project_Patches" wiki page where nothing about how many characters of the hash should be included. I'll keep that in mind. > >> That earlier change of yours didn't mean to do more than it did, by its > >> title and description. True. Had I known at that time that the fix is needed to be applied in multiple places, the commit message would look different. > >> We relatively recently introduced Amends:, which > >> may be a suitable fit here. So, what should be my next steps? Should I re-send the patch where I Cc Tamas, use 12-char hashes and replace Fixes with Amends? P.
