On 2026-01-05 15:58, Andrew Cooper wrote:
On 05/01/2026 2:55 pm, Jan Beulich wrote:
On 31.12.2025 12:22, Nicola Vetrini wrote:
--- a/xen/common/libelf/libelf-private.h
+++ b/xen/common/libelf/libelf-private.h
@@ -84,7 +84,9 @@
#define elf_err(elf, fmt, args ... ) \
elf_call_log_callback(elf, 1, fmt , ## args );
-void elf_call_log_callback(struct elf_binary*, bool iserr, const
char *fmt,...);
+void
+__attribute__ ((format (printf, 3, 4)))
+elf_call_log_callback(struct elf_binary*, bool iserr, const char
*fmt, ...);
Just one tiny, nit-like request here: If already you touch this, can
the
missing blank ahead of the first * please also be added at this
occasion?
The parameter also needs a name. I have both fixed up locally.
~Andrew
Thanks
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
