On 12.12.2025 05:02, Penny Zheng wrote:
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -216,7 +216,7 @@ long arch_do_domctl(
> {
>
> case XEN_DOMCTL_shadow_op:
> -#ifdef CONFIG_PAGING
> +#if defined(CONFIG_PAGING) && !defined(CONFIG_PV_SHIM_EXCLUSIVE)
> ret = paging_domctl(d, &domctl->u.shadow_op, u_domctl, 0);
> if ( ret == -ERESTART )
> return hypercall_create_continuation(
This, in the end, is open-coded PG_log_dirty afaict. Question then is why
not use PG_log_dirty here. If there is a good reason not to, it may want
spelling out in at least the description, maybe even a code comment here.
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -11,6 +11,7 @@ obj-$(filter-out $(CONFIG_X86),$(CONFIG_ACPI)) += device.o
> obj-$(CONFIG_DEVICE_TREE_PARSE) += device-tree/
> obj-$(CONFIG_IOREQ_SERVER) += dm.o
> obj-y += domain.o
> +obj-$(CONFIG_MGMT_HYPERCALLS) += domctl.o
> obj-y += domid.o
> obj-y += event_2l.o
> obj-y += event_channel.o
> @@ -70,9 +71,6 @@ obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2
> unxz unlzma lzo unlzo un
>
> obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o memory.o multicall.o
> xlat.o)
>
> -ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> -obj-$(CONFIG_MGMT_HYPERCALLS) += domctl.o
> -endif
>
> obj-$(CONFIG_COVERAGE) += coverage/
> obj-y += sched/
Nit: One of the two blank lines then wants to also go away.
Jan
