On Thu, Dec 04, 2025 at 04:37:10AM -0800, [email protected] wrote: > This is a follow-on mini-series based on the original feedback in [1]. > > Patch 1 addresses the remaining feedback from [1].
You mean the feedback about the comment? I guess that's addressed by removing the comment, there's just more unrelated changes in the patch. > Patch 2 adds a new fragment for auto-generating test harness dependencies. I feel like this second patch could be made useful, and easier to review, if a second user of Tests.mk was added. > [1] https://lore.kernel.org/xen-devel/aLmZLm2_G48yfPWR@l14/ > [2] CI: > https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2195624771 > > Denis Mukhin (2): > tests: fixup domid test harness dependencies > tests: introduce Tests.mk fragment > > tools/Tests.mk | 34 ++++++++++++++++++++++++++++++++++ If this new file is useful, could you move it "tools/tests/"? BTW, if we really want some generic test harness makefile, maybe looking at what was done for "tools/libs/libs.mk" for example. Cheers, -- Anthony PERARD
