Hi Bertrand, On Fri, Dec 5, 2025 at 11:37 AM Bertrand Marquis <[email protected]> wrote: > > Bring the FF-A headers up to the v1.2 baseline and fix the function-number > range used for ABI discovery: > > - update FFA_FNUM_MAX_VALUE so the FF-A function-number window covers the > full v1.2 range, and derive the ABI bitmap bounds from > FFA_FNUM_MIN_VALUE/FFA_FNUM_MAX_VALUE instead of hard-coding > FFA_ERROR/FFA_MSG_SEND2 > - define the new v1.2 function IDs; CONSOLE_LOG_32/64 and > PARTITION_INFO_GET_REGS are added for ABI discovery even though they are > not implemented yet > - extend the firmware ABI table to probe RUN and > MSG_SEND_DIRECT_REQ2/RESP2 > - while there, fix an off-by-one in ffa_fw_supports_fid(): the computed bit > index must be strictly smaller than FFA_ABI_BITMAP_SIZE, so use >= in the > bounds check > - Also fix comment as call IDs reserved for FF-A are from 0x60 to 0xEF > > Keep FFA_MY_VERSION at 1.1 for now; we only advertise v1.2 once the > implementation is fully compliant. > > Signed-off-by: Bertrand Marquis <[email protected]> > --- > Changes in v1: > - Add CONSOLE_LOG_64 and rename CONSOLE_LOG to CONSOLE_LOG_32 > - Set MAX value to 0x8E which is the highest abi value available in 1.2 > - Mention in ffa_private.h comment that SMCCC is actually reserving 0x60 > to 0xEF included for FF-A (and fix previous FF which was wrong). > --- > xen/arch/arm/include/asm/tee/ffa.h | 3 ++- > xen/arch/arm/tee/ffa.c | 4 ++++ > xen/arch/arm/tee/ffa_private.h | 21 +++++++++++++-------- > 3 files changed, 19 insertions(+), 9 deletions(-)
Looks good: Reviewed-by: Jens Wiklander <[email protected]> Cheers, Jens
