BALATON Zoltan <[email protected]> writes:
> On Thu, 20 Nov 2025, Daniel Henrique Barboza wrote:
>> On 11/19/25 10:08 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <[email protected]>
>>> ---
>>
>> Nice cleanup
>>
>>
>> Reviewed-by: Daniel Henrique Barboza <[email protected]>
[...]
>>> diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
>>> index b0bab3fe00..8531e1d121 100644
>>> --- a/hw/riscv/spike.c
>>> +++ b/hw/riscv/spike.c
>>> @@ -180,15 +180,7 @@ static void create_fdt(SpikeState *s, const
>>> MemMapEntry *memmap,
>>> static bool spike_test_elf_image(char *filename)
>>> {
>>> - Error *err = NULL;
>>> -
>>> - load_elf_hdr(filename, NULL, NULL, &err);
>>> - if (err) {
>>> - error_free(err);
>>> - return false;
>>> - } else {
>>> - return true;
>>> - }
>>> + return load_elf_hdr(filename, NULL, NULL, NULL);
>
> Does it worth to keep this function or could just be inlined at the two
> callers now that it's equivalent with load_elf_hdr?
Palmer, Alistair, Daniel, got a preference?
