On 13/11/2025 12:49 pm, Frediano Ziglio wrote: > From: Frediano Ziglio <[email protected]> > > For xen.gz file we strip all symbols and have an additional > xen-syms.efi file version with all symbols. > Make xen.efi more coherent stripping all symbols too. > xen-syms.efi can be used for debugging. > > Signed-off-by: Frediano Ziglio <[email protected]> > --- > Changes since v1: > - avoid leaving target if some command fails. > > Changes since v2: > - do not convert type but retain PE format; > - use xen-syms.efi for new file name, more consistent with ELF. > > Changes since v3: > - update documentation; > - do not remove xen.efi.elf; > - check endbr instruction before generating final target. > > Changes since v4: > - simplify condition check; > - avoid reuse of [email protected] file. > > Changes since v5: > - avoid creation of temporary file. > > Changes since v6: > - install xen-syms.efi; > - always strip xen.efi; > - restore EFI_LDFLAGS check during rule execution; > - update CHANGELOG.md; > - added xen-syms.efi to .gitignore. > --- > .gitignore | 1 + > CHANGELOG.md | 3 +++ > docs/misc/efi.pandoc | 8 +------- > xen/Kconfig.debug | 9 ++------- > xen/Makefile | 25 +++---------------------- > xen/arch/x86/Makefile | 11 ++++++++--- > 6 files changed, 18 insertions(+), 39 deletions(-) > > diff --git a/.gitignore b/.gitignore > index d83427aba8..213972b65c 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -222,6 +222,7 @@ tools/flask/policy/xenpolicy-* > xen/xen > xen/suppression-list.txt > xen/xen-syms > +xen/xen-syms.efi > xen/xen-syms.map > xen/xen.* > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index c9932a2af0..3bdcc3b47a 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -65,6 +65,9 @@ The format is based on [Keep a > Changelog](https://keepachangelog.com/en/1.0.0/) > for hypervisor mode. > > ### Removed > + - The install-time environment variable INSTALL_EFI_STRIP is no longer > + supported, xen.efi will is now always being stripped.
I'd rephrase this a little. "... INSTALL_EFI_STRIP no longer exists. xen.efi is always stripped, while the symbols remain available in xen-syms.efi." Personally, I'd have put this in the Changed section rather than Removed, but both can be adjusted together. This bug is on the 4.21 tracking list. CC'ing Oleksii. ~Andrew
