On 12.11.2025 21:18, Kevin Lampis wrote: > struct cpuinfo_x86 > .x86 => .family > .x86_vendor => .vendor > .x86_model => .model > .x86_mask => .stepping > > No functional change.
Needs you S-o-b. Also the subject is too generic - it gives the impression that you do the transformation for all of xen/arch/x86/. Then: Reviewed-by: Jan Beulich <[email protected]> albeit with two remarks: > @@ -657,8 +659,8 @@ static void cf_check init_intel(struct cpuinfo_x86 *c) > /* Work around errata */ > Intel_errata_workarounds(c); > > - if ((c->x86 == 0xf && c->x86_model >= 0x03) || > - (c->x86 == 0x6 && c->x86_model >= 0x0e)) > + if ((c->family == 0xf && c->model >= 0x03) || > + (c->family == 0x6 && c->model >= 0x0e)) > __set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); While you touch this, indentation also wants correcting. > --- a/xen/arch/x86/include/asm/intel-family.h > +++ b/xen/arch/x86/include/asm/intel-family.h > @@ -179,6 +179,10 @@ > #define INTEL_XEON_PHI_KNL IFM(6, 0x57) /* Knights Landing */ > #define INTEL_XEON_PHI_KNM IFM(6, 0x85) /* Knights Mill */ > > +/* Family 15 - NetBurst */ > +#define INTEL_P4_WILLAMETTE IFM(15, 0x01) /* Also Xeon Foster */ > +#define INTEL_P4_PRESCOTT IFM(15, 0x03) Any reason not to also add the other two that Linux has in this group: #define INTEL_P4_PRESCOTT_2M IFM(15, 0x04) #define INTEL_P4_CEDARMILL IFM(15, 0x06) /* Also Xeon Dempsey */ ? Jan
