Re: [PATCH v2 15/23] x86/pv: Deduplicate is_canonical_address() in do_set_segment_base()

[Jan Beulich]

On 28.08.2025 17:04, Andrew Cooper wrote:
> This is really a rearrangement to make adding FRED support easier.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> CC: Jan Beulich <jbeul...@suse.com>
> CC: Roger Pau Monné <roger....@citrix.com>
> 
> v2:
>  * New
> 
> There is a marginal code size improvement:
> 
>   add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-46 (-46)
>   Function                                     old     new   delta
>   do_set_segment_base                          496     450     -46

While this is quite nice, the nested switch()es aren't as much. Still
Acked-by: Jan Beulich <jbeul...@suse.com>
with possibly a default case added to the new inner switch(), just to
please Misra.

Jan