On Fri, Jul 20, 2018 at 02:29:34AM -0700, Zhenzhong Duan wrote: > No functional change. > > Signed-off-by: Zhenzhong Duan <zhenzhong.d...@oracle.com> > --- > xen/arch/x86/irq.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c > index 87ef2e8..5253fd1 100644 > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -2701,8 +2701,6 @@ int allocate_and_map_msi_pirq(struct domain *d, int > index, int *pirq_p, > return -EINVAL; > } > > - msi->irq = irq;
I would prefer to remove the assignment in the MAP_PIRQ_TYPE_MULTI_MSI case rather than here. IMO this one makes it clearer that msi->irq is always set. In any case: Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
