On 13/08/2025 1:55 pm, Roger Pau Monne wrote:
> Coverity complains that:
>
> 277 ma_va_bottom_mask = (PAGE_SIZE << bottom_shift) - 1;
I'd perhaps drop this line from the commit message. The sentence below
is fine, and there's only a single hunk so it's obvious what is being
referred to.
> In expression 0x1000 << bottom_shift, left shifting by more than 31 bits
> has undefined behavior. The shift amount, bottom_shift, is as much as 63.
>
> Cast PAGE_SIZE to paddr_t so it has the right width.
>
> Reported-by: Andrew Cooper <andrew.coop...@citrix.com>
> Coverity ID: 1662707
> Fixes: bac2000063ba ('x86-64: reduce range spanned by 1:1 mapping and frame
> table indexes')
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Formatting aside, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
