From: Nicola Vetrini <nicola.vetr...@bugseng.com> The enforced toolchain baseline for clang is version 11, therefore this logic is effectively dead code.
No functional change. Signed-off-by: Nicola Vetrini <nicola.vetr...@gmail.com> --- Mentioned in https://gitlab.com/xen-project/xen/-/issues/201 --- xen/common/coverage/llvm.c | 4 ---- xen/include/xen/self-tests.h | 9 +-------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/xen/common/coverage/llvm.c b/xen/common/coverage/llvm.c index 50d7a3c5d301..517b2aa8c202 100644 --- a/xen/common/coverage/llvm.c +++ b/xen/common/coverage/llvm.c @@ -44,12 +44,8 @@ ((uint64_t)'f' << 16) | ((uint64_t)'R' << 8) | ((uint64_t)129) #endif -#if __clang_major__ >= 4 || (__clang_major__ == 3 && __clang_minor__ >= 9) #define LLVM_PROFILE_VERSION 4 #define LLVM_PROFILE_NUM_KINDS 2 -#else -#error "clang version not supported with coverage" -#endif struct llvm_profile_data { uint64_t name_ref; diff --git a/xen/include/xen/self-tests.h b/xen/include/xen/self-tests.h index bd8a4867aa40..c57cceb3b962 100644 --- a/xen/include/xen/self-tests.h +++ b/xen/include/xen/self-tests.h @@ -10,16 +10,12 @@ #include <xen/lib.h> /* - * Check that fn(val) can be calcuated by the compiler, and that it gives the + * Check that fn(val) can be calculated by the compiler, and that it gives the * expected answer. * - * Clang < 8 can't fold constants through static inlines, causing this to - * fail. Simply skip it for incredibly old compilers. - * * N.B. fn is intentionally not bracketed to allow us to test function-like * macros too. */ -#if !defined(CONFIG_CC_IS_CLANG) || CONFIG_CLANG_VERSION >= 80000 #define COMPILE_CHECK(fn, val, res) \ do { \ typeof(fn(val)) real = fn(val); \ @@ -29,9 +25,6 @@ else if ( real != (res) ) \ BUILD_ERROR("Compile time check '" STR(fn(val) == res) "' failed"); \ } while ( 0 ) -#else -#define COMPILE_CHECK(fn, val, res) -#endif /* * Check that Xen's runtime logic for fn(val) gives the expected answer. This -- 2.43.0
