On 25.07.2025 08:30, Penny Zheng wrote:
> In order to fix CI error of a randconfig picking both PV_SHIM_EXCLUSIVE=y and
> HVM=y results in hvm.c being built, but domctl.c not being built, which leaves
> a few functions, like domctl_lock_acquire/release() undefined, causing linking
> to fail.
> To fix that, we intend to move domctl.o out of the PV_SHIM_EXCLUSIVE Makefile
> /hypercall-defs section, with this adjustment, we also need to remove
> redundant vnuma_destroy() stub definition to not break compilation.
> Above change will leave dead code in the shim binary temporarily and will be
> fixed with the introduction of CONFIG_DOMCTL.
>
> Fixes: 568f806cba4c ("xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE"")
> Reported-by: Jan Beulich <jbeul...@suse.com>
> Signed-off-by: Penny Zheng <penny.zh...@amd.com>
It seems pretty clear that this patch is what causes
ld: prelink.o: in function `arch_do_domctl':
(.text+0x5b85d): undefined reference to `paging_domctl'
(.text+0x5b85d): relocation truncated to fit: R_X86_64_PLT32 against undefined
symbol `paging_domctl'
ld: ./.xen-syms.0: hidden symbol `paging_domctl' isn't defined
ld: final link failed: bad value
throughout the various build jobs in CI. Considering prior issues I feel
urged to ask whether you actually tested your change.
Jan
