On 22.07.2025 13:41, Oleksii Moisieiev wrote: > Change -ENOPNOTSUPP error code to -ENXIO when iommu is disabled during > iommu_do_domctl call. As was discussed in [1] > > [0]: > https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2506171701190.1780597@ubuntu-linux-20-04-desktop/
Hmm, I can't read any justification for the choice of the particular error code out of that email. How's ENXIO going to be (and remain) unique? If you need a specific indication of the IOMMU being disabled, I think you want to have a specific query for that. Assuming XEN_SYSCTL_PHYSCAP_directio isn't enough (for whatever reason). Jan