On Mon, Jul 21, 2025 at 1:13 PM Orzel, Michal <michal.or...@amd.com> wrote:
>
>
>
> On 21/07/2025 11:07, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
> > ---
> > xen/arch/arm/efi/efi-boot.h | 33 ++++++++++++---------------------
> > 1 file changed, 12 insertions(+), 21 deletions(-)
> >
> > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> > index 3dbeed3f89..a2aede21d5 100644
> > --- a/xen/arch/arm/efi/efi-boot.h
> > +++ b/xen/arch/arm/efi/efi-boot.h
> > @@ -79,8 +79,7 @@ static int __init setup_chosen_node(void *fdt, int
> > *addr_cells, int *size_cells)
> > prop = fdt_get_property(fdt, node, "#address-cells", &len);
> > if ( !prop )
> > {
> > - val = cpu_to_fdt32(2);
> > - if ( fdt_setprop(fdt, node, "#address-cells", &val, sizeof(val)) )
> > + if ( fdt_setprop_u32(fdt, node, "#address-cells", 2) )
> > return -1;
> > *addr_cells = 2;
> > }
> > @@ -90,8 +89,7 @@ static int __init setup_chosen_node(void *fdt, int
> > *addr_cells, int *size_cells)
> > prop = fdt_get_property(fdt, node, "#size-cells", &len);
> > if ( !prop )
> > {
> > - val = cpu_to_fdt32(2);
> > - if ( fdt_setprop(fdt, node, "#size-cells", &val, sizeof(val)) )
> > + if ( fdt_setprop_u32(fdt, node, "#size-cells", 2) )
> > return -1;
> > *size_cells = 2;
> > }
> > @@ -251,8 +249,6 @@ static EFI_STATUS __init
> > fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table,
> > {
> > int node;
> > int status;
> > - u32 fdt_val32;
> > - u64 fdt_val64;
> > int num_rsv;
> >
> > /*
> > @@ -275,33 +271,28 @@ static EFI_STATUS __init
> > fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table,
> > }
> > }
> >
> > - fdt_val64 = cpu_to_fdt64((u64)(uintptr_t)sys_table);
> > - status = fdt_setprop(fdt, node, "linux,uefi-system-table",
> > - &fdt_val64, sizeof(fdt_val64));
> > + status = fdt_setprop_u64(fdt, node, "linux,uefi-system-table",
> > + (uintptr_t)sys_table);
> Don't we need explicit cast here? In other words, why did you drop them?
>
It's not needed, if the compiler is not truncating it will do the
conversion correctly, in case of truncation it will trigger a warning
which we can deal with in the possible future.
> Other than that:
> Reviewed-by: Michal Orzel <michal.or...@amd.com>
>
> ~Michal
>
Frediano
