On 18/07/2025 10:41 am, Frediano Ziglio wrote: > PrintMessage function print a message string followed by a > new line. > Move the function from ARM specific code to common code. > Reuse it in EFI code. > No functional changes. > > Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
Please no. Hiding \n (or \r\n) in strings is an antipattern and a source of confusion that we do not want in Xen. Instead, delete PrintMessage() and convert ARM to use PrintStr(). That looks like it was premature anti-optimisation. You save 4 bytes per string, but it costs 12 byte minimum in .text to set up the function call, let alone the function call itself. ~Andrew
