On Tue Jun 24, 2025 at 9:24 AM CEST, dmkhn wrote: > On Tue, Jun 24, 2025 at 08:13:08AM +0200, Orzel, Michal wrote: >> >> >> On 24/06/2025 05:55, dm...@proton.me wrote: >> > From: Denis Mukhin <dmuk...@ford.com> >> > >> > Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011. >> Why? We emulate SBSA UART and not PL011. Despite the similarities (the >> former is >> a subset of the latter) they are not the same. I find it confusing and >> drivers >> for PL011 might not work with SBSA UART. Also, in the future we may want to >> emulate full PL011 in which case it will be even more confusing. > > That's because the emulator is called vpl011, but yes, it is SBSA UART. > I will adjust to SBSA, thanks! > >> >> Also, why HAS_? > > My understanding is that HAS_ is the desired naming convention throughout the > code (not documented, though), e.g. all Arm UART drivers are gated by HAS_XXX > (e.g. arch/arm/platforms/Kconfig).
HAS_ is a non-selectable property dependent on the arch. Think HAS_PCI, or HAS_EHCI, etc. IOW: HAS_X means "you may implement feature X on this arch", which is why some options have X and HAS_X variants, where X is selectable while HAS_X is not. Cheers, Alejandro
