Hi, > On 17 Jul 2025, at 08:20, Jan Beulich <jbeul...@suse.com> wrote: > > On 15.07.2025 11:31, Dmytro Prokopchuk1 wrote: >> Rule 10.1: Operands shall not be of an >> inappropriate essential type >> >> The following are non-compliant: >> - boolean used as a numeric value. >> >> The result of the '__isleap' macro is a boolean. >> Suppress analyser tool finding. >> >> The result of 'NOW() > timeout' is a boolean, >> which is compared to a numeric value. Fix this. >> Regression was introdiced by commit: >> be7f047e08 (xen/arm: smmuv3: Replace linux functions with xen functions.) >> >> Remove pointless cast '(const unsigned short int *)'. >> The source array and the destination pointer are both of the same type. >> >> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopch...@epam.com> > > I assume you put this in implicitly ... > >> --- >> docs/misra/safe.json | 8 ++++++++ >> xen/common/time.c | 3 ++- >> xen/drivers/passthrough/arm/smmu-v3.c | 2 +- >> 3 files changed, 11 insertions(+), 2 deletions(-) > > ... acking the Arm part? Except that it would have been Bertrand or Rahul > to ack this?
This was definitely not meant to be like this in the code so the fix is right: For the SMMU part: Acked-by: Bertrand Marquis <bertrand.marq...@arm.com> Cheers Bertrand > > Jan
