On 16.07.2025 17:45, Andrew Cooper wrote:
> On 16/07/2025 2:47 pm, Jan Beulich wrote:
>> On 16.07.2025 15:28, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/include/asm/cpufeature.h
>>> +++ b/xen/arch/x86/include/asm/cpufeature.h
>>> @@ -20,10 +20,30 @@
>>> #ifndef __ASSEMBLY__
>>>
>>> struct cpuinfo_x86 {
>>> - unsigned char x86; /* CPU family */
>>> - unsigned char x86_vendor; /* CPU vendor */
>>> - unsigned char x86_model;
>>> - unsigned char x86_mask;
>>> + /* TODO: Phase out the x86 prefixed names. */
>>> + union {
>>> + struct {
>>> + union {
>>> + uint8_t x86_model;
>>> + uint8_t model;
>>> + };
>>> + union {
>>> + uint8_t x86;
>>> + uint8_t family;
>>> + };
>>> + union {
>>> + uint8_t x86_vendor;
>>> + uint8_t vendor;
>>> + };
>>> + uint8_t _rsvd;
>> Can we perhaps name this e.g. _zero, so it's clear that it cannot be
>> repurposed?
>
> It can be repurposed; it just must be done in coordination with VFM_MAKE().
Hmm, true.
> I can add a comment to this effect, but it would need to be in the
> subsequent patch when VFM_MAKE() is introduced.
Okay, and thanks.
Jan
