On 12/02/2024 12:53 pm, Jan Beulich wrote:
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -413,6 +413,19 @@ void __init early_cpu_init(bool verbose)
>       initialize_cpu_data(0);
>  }
>  
> +void reset_cpuinfo(struct cpuinfo_x86 *c, bool keep_basic)
> +{
> +     if (!keep_basic) {
> +             c->x86 = c->x86_vendor = 0;     /* So far unknown... */
> +             c->x86_model = c->x86_mask = 0; /* So far unknown... */

You're going to need to turn these into 4 separate assignments for MISRA
reasons.

I'm not sure of the value of keeping the "So far unknown" comment.

Also, can we please switch to Xen style as we're doing elsewhere in
these not-really-Linux-any-more files.

With that, Acked-by: Andrew Cooper <andrew.coop...@citrix.com>

Reply via email to