On Mon, 30 Jun 2025, Luca Fancellu wrote: > Hi Michal, > > > On 25 Jun 2025, at 11:12, Michal Orzel <michal.or...@amd.com> wrote: > > > > At the moment, we unconditionally allocate space for grant table region > > membank and add it in the membanks array to find_unallocated_memory() to > > find unused memory. In case of CONFIG_GRANT_TABLE=n, the size of the > > region is empty and assertion in rangeset_remove_range() fails when > > booting hwdom or 1:1 domU without IOMMU. Example: > > > > (XEN) Assertion 's <= e' failed at common/rangeset.c:189 > > ... > > (XEN) Xen call trace: > > (XEN) [<00000a0000218b5c>] rangeset_remove_range+0xbc/0x2d4 (PC) > > (XEN) [<00000a00002b8370>] find_unallocated_memory+0x140/0x208 (LR) > > (XEN) [<00000a00002cc28c>] make_hypervisor_node+0x310/0x7e0 > > ... > > > > Same issue would occur when booting hwdom with LLC coloring enabled. > > Fix it by performing conditional allocation and configuration. > > > > Signed-off-by: Michal Orzel <michal.or...@amd.com> > > The patch looks good to me, I’ve reproduced locally the issue and tested that > this patch > solves it, using FVP. > > Reviewed-by: Luca Fancellu <luca.fance...@arm.com> > Tested-by: Luca Fancellu <luca.fance...@arm.com>
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
