[Public]
> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: Tuesday, June 17, 2025 12:22 AM
> To: Penny, Zheng <penny.zh...@amd.com>
> Cc: Huang, Ray <ray.hu...@amd.com>; xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v5 12/18] xen/cpufreq: get performance policy from
> governor
> set via xenpm
>
> On 27.05.2025 10:48, Penny Zheng wrote:
> > --- a/xen/drivers/acpi/pmstat.c
> > +++ b/xen/drivers/acpi/pmstat.c
> > @@ -319,6 +319,14 @@ static int set_cpufreq_gov(struct xen_sysctl_pm_op
> *op)
> > if (new_policy.governor == NULL)
> > return -EINVAL;
> >
> > + new_policy.policy = cpufreq_policy_from_governor(new_policy.governor);
> > + if ( new_policy.policy == CPUFREQ_POLICY_UNKNOWN )
> > + {
> > + printk("Failed to get performance policy from %s, and users
> > + shall write epp values to deliver preference towards performance
> > + over efficiency",
>
> This message is excessively long and is lacking a newline (i.e. effectively
> two:
> one in the middle and one at the end; yet better would be to find less verbose
> wording). What's worse, how would a "user" go about "writing epp values"?
>
Maybe change it to
```
printk("Failed to get performance policy from %s, Try \"xenpm
set-cpufreq-cppc\"\n", ...);
```
> Jan
