Hi Jan,
On 02/07/2025 14:06, Jan Beulich wrote:
When the bumping by <nr> (instead of just 1) was introduced, a comment
was left untouched, and a bogus ASSERT_UNREACHABLE() was inserted. That
code path can in principle be taken (depending on configuration coming
from the outside), and we shouldn't assert anything we didn't check
elsewhere.
I suggested to add the ASSERT_UNREACHABLE (see [1]). My take is the
overflow is not something that should happen and it is good to be able
to catch very clearly in debug build.
So I am reluctant to remove it at the moment.
Cheers,
[1]
https://lore.kernel.org/xen-devel/47b4d6c2-3bc7-02bc-be5a-a2b782541...@xen.org/
--
Julien Grall
