On 02.07.2025 01:45, Petr Beneš wrote: > --- a/tools/firmware/hvmloader/smbios.c > +++ b/tools/firmware/hvmloader/smbios.c > @@ -385,7 +385,7 @@ smbios_type_0_init(void *start, const char *xen_version, > uint32_t length; > > pts = get_smbios_pt_struct(0, &length); > - if ( pts != NULL && length > 0 ) > + if ( pts != NULL && length >= sizeof(struct smbios_type_0) )
Please preferably use an actual variable that's available, i.e. sizeof(*p) in cases like this one. Also, patch 1 touched this very line. Adjusting style while touching a line is quite fine, and typically even preferred over touching the same line twice in close succession. > @@ -504,7 +504,7 @@ smbios_type_2_init(void *start) > unsigned int counter = 0; > > pts = get_smbios_pt_struct(2, &length); > - if ( pts != NULL && length > 0 ) > + if ( pts != NULL && length >= 8 ) No way to have (even uncommented) literal numbers like this in the code. This can be expressed using offsetof(), I expect, and hence wants expressing that way. Seeing the respective member's name will then also aid reviewing. Jan
