On 16.06.2025 08:41, Penny Zheng wrote: > Remove all "depends on !PV_SHIM_EXCLUSIVE" (also the functionally > equivalent "if !...") in Kconfig file, since negative dependancy will badly > affect allyesconfig. > > Signed-off-by: Penny Zheng <penny.zh...@amd.com> > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > v2 -> v3: > - remove comment for PV_SHIM_EXCLUSIVE > --- > v3 -> v4: > - explicitly state "CONFIG_xxx is not set" in "pvshim_defconfig"
Where did these changes go? Nothing is said about ... > - Add "default y" for SHADOW_PAGING and TBOOT > - refactor commit message > --- > v4 -> v5: > - For not breaking allyesconfig, changes to defaults are actually not needed. > So remove them all > - Leave one blank lines ... their (complete) dropping here. Aiui overrides for anything where you remove the dependency (and where the intended setting for the shim is different from the general default) would still be needed here. And then there's still a non-"depends on" change left ... > --- a/xen/drivers/video/Kconfig > +++ b/xen/drivers/video/Kconfig > @@ -3,7 +3,7 @@ config VIDEO > bool > > config VGA > - bool "VGA support" if !PV_SHIM_EXCLUSIVE > + bool "VGA support" > select VIDEO > depends on X86 > default y if !PV_SHIM_EXCLUSIVE ... here, which (as indicated before) imo doesn't belong here, but at the very least would need covering in the description. Also, just to repeat what I said in reply to the cover letter: Imo this change needs to move 2nd to last in the series, and it then wants committing together with the last patch (which you will want to put in as a remark to the eventual committer). Jan
