On Mon, Jun 23, 2025 at 03:40:24PM +0200, Orzel, Michal wrote:
> 
> 
> On 21/06/2025 17:11, Koichiro Den wrote:
> > Even though make_hypervisor_node() does not rely on the /reserved-memory
> > instantiation when calling find_unused_regions() (the wrapper introduced
> > in the previous commit), the next but one commit will use it for PV time
> Unless for specific reasons, you should not rely on which commit gets 
> committed
> first. Hypothetically there could be a different patch committed between this
> and the next one in your series. That's why it's not a good practice to 
> mention
> order of commits in the commit message.

That makes sense. I'll rewrite the commit messages in v2.
Thank you for the review.

> 
> > shared regions, in addition to the existing extended regions.
> > 
> > Move it as a prerequisite for the commit after next.
> This one is particularly not useful.
> 
> > 
> > No functional changes intended.
> > 
> > Signed-off-by: Koichiro Den <d...@valinux.co.jp>
> 
> Other than that, LGTM.
> 
> ~Michal
> 

Reply via email to